Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345001: java/awt/doc-files/FocusSpec.html has SecurityManager references #22377

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Nov 26, 2024

Remove references to SecurityManager related functionality from the AWT Focus Specification

non-goal : generally updating the Focus Spec ..

Please review the CSR too https://bugs.openjdk.org/browse/JDK-8345002

note the CSR excludes a few lines that are not spec. significant


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8345002 to be approved

Issues

  • JDK-8345001: java/awt/doc-files/FocusSpec.html has SecurityManager references (Bug - P4)
  • JDK-8345002: java/awt/doc-files/FocusSpec.html has SecurityManager references (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22377/head:pull/22377
$ git checkout pull/22377

Update a local copy of the PR:
$ git checkout pull/22377
$ git pull https://git.openjdk.org/jdk.git pull/22377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22377

View PR using the GUI difftool:
$ git pr show -t 22377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22377.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 26, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345001: java/awt/doc-files/FocusSpec.html has SecurityManager references

Reviewed-by: azvegint, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • 28c8729: 8343004: Adjust JAXP limits
  • 8c2b4f6: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration
  • 8389e24: 8345058: Javac issues different error messages for the modifiers of the requires directive
  • 8da6435: 8343693: [JVMCI] Override ModifiersProvider.isConcrete in ResolvedJavaType to be isArray() || !isAbstract()
  • 7ae6069: 8344184: Remove sun.net.ResourceManager after JEP 486 integration
  • 1d5587b: 8344256: Clean up obsolete code in java.desktop/share/classes/sun/awt/datatransfer/DataTransferer.java
  • 5e15415: 8344654: Some client tests still expect a SecurityManager after JEP486
  • 3689f39: 8344013: "bad tag in log" assert with +LogCompilation +CITimeVerbose
  • 9458a43: 8318416: Superscript marks should use consistent font style
  • c5de307: 8344992: Remove Security Manager dependencies from java.security.cert API and implementations
  • ... and 27 more: https://git.openjdk.org/jdk/compare/027607968b3d55b498e9f2d7a4023b8ae2d47b5b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8345001 8345001: java/awt/doc-files/FocusSpec.html has SecurityManager references Nov 26, 2024
@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Nov 26, 2024
@openjdk
Copy link

openjdk bot commented Nov 26, 2024

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Nov 26, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Nov 26, 2024
@prrace
Copy link
Contributor Author

prrace commented Nov 27, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

Going to push as commit 8ad0b2a.
Since your change was applied there have been 61 commits pushed to the master branch:

  • f6d2990: 8344824: CDS dump crashes when member_method of a lambda proxy is null
  • 15378a7: 8345126: [BACKOUT] JDK-8318127: align_up has potential overflow
  • 880f9a7: 8344220: Remove calls to SecurityManager and doPrivileged in java.net.InetAddress and sun.net.util.IPAddressUtil after JEP 486 integration
  • 9527586: 8345073: Remove SecurityManager checks from sun.awt.image classes
  • 1e3a0fd: 8035271: Incorrect indentation of LineNumberTable/LocalVariableTable/Exception table/LocalVariableTypeTable/StackMapTable/RuntimeVisibleTypeAnnotations in verbose mode
  • 0312694: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory
  • 75f3ec7: 8344766: AES/CTR slow at big payloads
  • 35bd2f3: 8344555: SM cleanup - drop reflection filter of System.security field
  • a491564: 8342836: Automatically determine that a test in the docs test root is requested
  • b89cba7: 8342808: Javadoc should add whitespace between type parameters
  • ... and 51 more: https://git.openjdk.org/jdk/compare/027607968b3d55b498e9f2d7a4023b8ae2d47b5b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 27, 2024
@openjdk openjdk bot closed this Nov 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 27, 2024
@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@prrace Pushed as commit 8ad0b2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants